Pong Help 2

Yes, one$ and two$ should be Global, however Const might be better, because they don't change.

const one$ = "1"

Else, they are empty in the welcome() Function.
Then, the welcome function should be placed after creating the ball and the two players (type instances)